Skip to content

Conversation

@codomposer
Copy link
Contributor

@codomposer codomposer commented Oct 30, 2025

Fixes

Closes #1734
Closes #1755
Closes #1767

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 97.439% (-0.3%) from 97.735%
when pulling 9f30952 on codomposer:fix/trans_less_than_sign
into badbfa3 on i18next:master.

@adrai adrai merged commit e0e882f into i18next:master Oct 30, 2025
7 of 9 checks passed
@adrai
Copy link
Member

adrai commented Oct 30, 2025

thx, it's included in v16.2.2

@christophemenager
Copy link

I am not sure to understand the issue fixed with this PR but it breaks my usage:

  "noGameCodeModal": {
    "subtitle1": "It is not possible to obtain a code from our mobile application, but only from our website: <website-link>mywebsite.fr</website-link>",
  },
  <Trans
            defaults={t('noGameCodeModal.subtitle1')}
            components={{
              'website-link': (
                <Text
                  textDecorationLine="underline"
                  variant="body1_bold"
                  color="secondary"
                  onPress={() => {
                    Linking.openURL('myWebsite.fr');
                  }}
                />
              ),
            }}
          />

Is there something I was previously doing wrong? If not, maybe this change should be at least minor or major as it's breaking

@christophemenager
Copy link

@adrai let met know if you want me to open an new issue

@adrai
Copy link
Member

adrai commented Oct 30, 2025

@codomposer can you please have a look at this, else we'll need to revert your PR... (I suspect, to fix this properly we need this to land)

@codomposer
Copy link
Contributor Author

@christophemenager
can you elaborate more on your issue? any logs or expected behavior

@christophemenager
Copy link

Expected behavior (without this PR) Current behavior (with this PR
IMG_0071 IMG_F967CA6A82DD-1

@adrai
Copy link
Member

adrai commented Oct 30, 2025

@adrai
Copy link
Member

adrai commented Oct 30, 2025

@codomposer
Copy link
Contributor Author

I am on it, will push a hotfix

@codomposer
Copy link
Contributor Author

@adrai @christophemenager
#1882
hope this should fix the issue

@adrai
Copy link
Member

adrai commented Oct 30, 2025

@christophemenager please try with v16.2.3

@christophemenager
Copy link

v16.2.3 fixes the issue, nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiline Text Not Rendering Correctly in react-i18next" default wrap component ? Less than sign < breaks tag parsing with Trans component

4 participants