-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix trans component break with less than sign #1880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thx, it's included in v16.2.2 |
|
I am not sure to understand the issue fixed with this PR but it breaks my usage: Is there something I was previously doing wrong? If not, maybe this change should be at least minor or major as it's breaking |
|
@adrai let met know if you want me to open an new issue |
|
@codomposer can you please have a look at this, else we'll need to revert your PR... (I suspect, to fix this properly we need this to land) |
|
@christophemenager |
|
@christophemenager maybe you can create an appropriate test here? https://github.com/i18next/react-i18next/blob/master/test/trans.render.object.spec.jsx |
|
I am on it, will push a hotfix |
|
@adrai @christophemenager |
|
@christophemenager please try with v16.2.3 |
|
v16.2.3 fixes the issue, nice job! |

Fixes
Closes #1734
Closes #1755
Closes #1767
Checklist
npm run testChecklist (for documentation change)