Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppresses required context type warning if passing i18n as a prop #205

Merged
merged 2 commits into from Sep 25, 2016

Conversation

@Alex509
Copy link
Contributor

Alex509 commented Sep 23, 2016

There is a new feature added to pass i18n as a prop (for example using DI) but React emits a warning (Required context type i18n is missing)
References #203

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 23, 2016

Coverage Status

Coverage remained the same at 60.377% when pulling 58b6c8e on Alex509:master into 7b211fb on i18next:master.

@jamuhl jamuhl merged commit 97cf874 into i18next:master Sep 25, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 60.377%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Sep 25, 2016

thank you for the PR. merged and published in react-i18next@1.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.