Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #247: PropTypes warnings. #248

Merged
merged 1 commit into from Apr 10, 2017
Merged

Fix #247: PropTypes warnings. #248

merged 1 commit into from Apr 10, 2017

Conversation

@kadishmal
Copy link
Contributor

kadishmal commented Apr 10, 2017

Fix #247: PropTypes warnings.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 10, 2017

Coverage Status

Coverage increased (+1.5%) to 54.839% when pulling 9f60a3c on kadishmal:247 into 42d1a7b on i18next:master.

@kadishmal

This comment has been minimized.

Copy link
Contributor Author

kadishmal commented Apr 10, 2017

  1. @jamuhl how about updating the react dependency as well? In fact all other dependencies.
  2. Will up change the version, or should I do that?
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Apr 10, 2017

will check later when out of office and home again - thanks for providing this...really thankful for timesaving - expect it to be published later today.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Apr 10, 2017

  1. updating deps is ok for me - normally i do them pre publish - when doing a minor version (not for all patch versions)

Will update the version of react-i18next before publishing

@jamuhl jamuhl merged commit b3d4d53 into i18next:master Apr 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.5%) to 54.839%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Apr 10, 2017

wonder if we should move react and prop-types to peerDependencies

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Apr 10, 2017

just published react-i18next@3.0.0

made it major - so people are aware of needing to have prop-types installed on the main project.

@kadishmal kadishmal deleted the kadishmal:247 branch Apr 11, 2017
@kadishmal

This comment has been minimized.

Copy link
Contributor Author

kadishmal commented Apr 11, 2017

@jamuhl agree on moving React and and PropTypes into peer deps. Thanks for the merge!

@jamuhl jamuhl mentioned this pull request May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.