Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround to set ready if there was no initialized signal #263

Merged
merged 1 commit into from Jun 12, 2017

Conversation

@jussikinnula
Copy link
Contributor

jussikinnula commented Jun 12, 2017

I have now tested that the problem originally (to need this workaround) was because of misuse of i18next initialization.

The updated code is at:
https://github.com/jussikinnula/react-starter/tree/typescript-i18next

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 12, 2017

Coverage Status

Coverage decreased (-0.05%) to 94.017% when pulling dab3e84 on jussikinnula:master into 5e4f27b on i18next:master.

@jamuhl jamuhl merged commit d79621b into i18next:master Jun 12, 2017
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.05%) to 94.017%
Details
codeclimate 1 fixed issue
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jun 12, 2017

Thank you...wasn't aware i did merge that code part too (wasn't my intend)...published update removing this.

@jussikinnula

This comment has been minimized.

Copy link
Contributor Author

jussikinnula commented Jun 12, 2017

I'll keep in mind to make separate PR's for each patch in future, it was my fault too!

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jun 12, 2017

Idk..thought i looked into changes...and there were only the parts for options...never mind...all green now again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.