Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Trans parent element configurable. #278

Merged
merged 1 commit into from Jul 25, 2017
Merged

Conversation

@wichert
Copy link
Contributor

wichert commented Jul 25, 2017

This fixes #276

This fixes #276
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jul 25, 2017

awesome...will check this later. merge and publish an update.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage increased (+0.1%) to 87.745% when pulling a4a1b34 on curvetips:trans-parent into 4b05e4f on i18next:master.

@jamuhl jamuhl merged commit 422815d into i18next:master Jul 25, 2017
2 of 3 checks passed
2 of 3 checks passed
codeclimate 3 issues to fix
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 87.745%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jul 25, 2017

thank you for the PR. update was published with react-i18next@4.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.