Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePureComponent option #357

Merged
merged 5 commits into from Dec 13, 2017
Merged

Add usePureComponent option #357

merged 5 commits into from Dec 13, 2017

Conversation

@ahoseinian
Copy link

ahoseinian commented Dec 5, 2017

No description provided.

Amir Hoseinian
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 5, 2017

Coverage Status

Coverage decreased (-1.03%) to 81.25% when pulling 39e9468 on ahoseinian:master into 4276370 on i18next:master.

Amir Hoseinian
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 5, 2017

Coverage Status

Coverage decreased (-1.03%) to 81.25% when pulling c3ff34d on ahoseinian:master into 4276370 on i18next:master.

Amir Hoseinian
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 5, 2017

Coverage Status

Coverage decreased (-1.03%) to 81.25% when pulling a3bd945 on ahoseinian:master into 4276370 on i18next:master.

Copy link
Member

jamuhl left a comment

what about the import shallowEqual from 'fbjs/lib/shallowEqual'; dependency introduced?

@@ -1,6 +1,7 @@
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import hoistStatics from 'hoist-non-react-statics';
import shallowEqual from 'fbjs/lib/shallowEqual';

This comment has been minimized.

Copy link
@jamuhl

jamuhl Dec 6, 2017

Member

does that not need additional dependency fbjs?

if so i would prefer not pulling in a that heavy dependency and prefer copy over of: https://github.com/facebook/fbjs/blob/master/packages/fbjs/src/core/shallowEqual.js

This comment has been minimized.

Copy link
@ahoseinian

ahoseinian Dec 6, 2017

Author

As we are already dependent to React and react is dependent to fbjs I thought this is ok! however if you think copying shallowEqual is a better option I can change it?

This comment has been minimized.

Copy link
@jamuhl

jamuhl Dec 6, 2017

Member

runs also in preact -> that's why pulling in a dependency of react is a bad idea

This comment has been minimized.

Copy link
@ahoseinian

ahoseinian Dec 6, 2017

Author

oh I see

Amir Hoseinian
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 6, 2017

Coverage Status

Coverage decreased (-5.7%) to 76.563% when pulling 1cec3d1 on ahoseinian:master into 4276370 on i18next:master.

Amir Hoseinian
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 6, 2017

Coverage Status

Coverage decreased (-5.7%) to 76.563% when pulling 589508b on ahoseinian:master into 4276370 on i18next:master.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Dec 6, 2017

would it be possible to add a test case? so we get coverage up again...regarding the codeclimate that shallowEqual file could be excluded in the codeclimate.yml

@jamuhl jamuhl merged commit 114f9e0 into i18next:master Dec 13, 2017
1 of 3 checks passed
1 of 3 checks passed
codeclimate 2 issues to fix
Details
coverage/coveralls Coverage decreased (-5.7%) to 76.563%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Dec 13, 2017

published with react-i18next@7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.