Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to props in constructor #411

Merged
merged 1 commit into from Mar 22, 2018
Merged

Conversation

@mjfaga
Copy link
Contributor

mjfaga commented Mar 21, 2018

In <=IE10, this.props is null, so when attempting to set the namespaces,
the reference to this.props.ns raises an exception. By updating the
reference to use the version passed into the constructor, we are
consistent with other usages of props on the constructor, and I've
confirmed this patch works in <=IE10 as well.

Mark Faga
In <=IE10, `this.props` is null, so when attempting to set the namespaces,
the reference to `this.props.ns` raises an exception. By updating the
reference to use the version passed into the constructor, we are
consistent with other usages of props on the constructor, and I've
confirmed this patch works in <=IE10 as well.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 21, 2018

Coverage Status

Coverage remained the same at 81.481% when pulling 1503902 on mjfaga:master into fec5f5f on i18next:master.

@jamuhl jamuhl merged commit eb167f5 into i18next:master Mar 22, 2018
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 81.481%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Mar 22, 2018

thank you...published in react-i18next@7.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.