Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require `i18n` in context #474

Merged
merged 1 commit into from Jul 12, 2018
Merged

Don't require `i18n` in context #474

merged 1 commit into from Jul 12, 2018

Conversation

@kevva
Copy link
Contributor

kevva commented Jul 12, 2018

Since it can be passed in as a prop, we shouldn't require it to be present in context.

Fixes #473.

Fixes #473.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 12, 2018

Coverage Status

Coverage remained the same at 82.041% when pulling b334c3b on kevva:remove-required-i18n into cadbe69 on i18next:master.

@jamuhl jamuhl merged commit 2389ea8 into i18next:master Jul 12, 2018
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 82.041%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jul 12, 2018

published in react-i18next@7.8.1

sindresorhus added a commit to atomiclabs/hyperdex that referenced this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.