Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't polyfill Object.entries globally #476

Merged
merged 1 commit into from Jul 16, 2018
Merged

Conversation

@goto-bus-stop
Copy link
Contributor

goto-bus-stop commented Jul 15, 2018

Patching Object.entries affects other code beyond this library, which
ideally should not happen. With this patch the polyfill is still used
when necessary but the global environment is not unexpectedly changed by
including react-i18next :)

Patching `Object.entries` affects other code beyond this library, which
ideally should not happen. With this patch the polyfill is still used
when necessary but the global environment is not unexpectedly changed by
including react-i18next :)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 15, 2018

Coverage Status

Coverage increased (+1.01%) to 83.051% when pulling f9e1f9d on goto-bus-stop:no-global into 02bffe8 on i18next:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 15, 2018

Coverage Status

Coverage increased (+1.01%) to 83.051% when pulling f9e1f9d on goto-bus-stop:no-global into 02bffe8 on i18next:master.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jul 15, 2018

will be merged and published with next version

@jamuhl jamuhl merged commit 5ad9cbd into i18next:master Jul 16, 2018
3 checks passed
3 checks passed
codeclimate 1 fixed issue
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.01%) to 83.051%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.