Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped custom html tags #482

Merged
merged 1 commit into from Jul 26, 2018
Merged

Skipped custom html tags #482

merged 1 commit into from Jul 26, 2018

Conversation

@hrnik
Copy link

hrnik commented Jul 25, 2018

Description

Fixed the bug, with empty html tags in source for Trans component.
Translators can (yes, they can) add some html tag into translations.

For example we had source

{
 "key" : "Some text <1>other text<1>"
}

But translations manager decide to add some tags in translations:
"Some text <br /> <1>other text<1>"

After that react-i18next throw the error

    TypeError: Cannot read property 'content' of undefined

      at src/Trans.js:78:86
          at Array.reduce (<anonymous>)
nkhristinin
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 25, 2018

Coverage Status

Coverage increased (+0.1%) to 82.661% when pulling 7532331 on hrnik:master into 1dc13d3 on i18next:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 25, 2018

Coverage Status

Coverage increased (+0.1%) to 82.661% when pulling 7532331 on hrnik:master into 1dc13d3 on i18next:master.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jul 25, 2018

thanks for creating the PR. Will check this tomorrow and merge it. Just came back from a two day trip - so won't be able to pull it in before tomorrow.

@jamuhl jamuhl merged commit 2e2a81c into i18next:master Jul 26, 2018
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 82.661%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jul 26, 2018

thank you...published in react-i18next@7.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.