Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related to issue #504: also report default Namespace with translate() #506

Merged
merged 1 commit into from Sep 3, 2018

Conversation

@olivierpascal
Copy link
Contributor

olivierpascal commented Sep 3, 2018

I also chose to report undefined when no namespace is used with translate() and no default namespace is defined in options.

olivierpascal
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 3, 2018

Coverage Status

Coverage remained the same at 82.937% when pulling afc3a5c on olivierpascal:reportDefaultNamespace into b702d54 on i18next:master.

@jamuhl jamuhl merged commit 1cba999 into i18next:master Sep 3, 2018
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 82.937%
Details
@olivierpascal olivierpascal deleted the olivierpascal:reportDefaultNamespace branch Sep 3, 2018
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Sep 3, 2018

thanks again - was published in react-i18next@7.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.