Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings for HOC's and fix imports #567

Merged
merged 5 commits into from Oct 25, 2018
Merged

Improve typings for HOC's and fix imports #567

merged 5 commits into from Oct 25, 2018

Conversation

@schettino
Copy link
Collaborator

schettino commented Oct 23, 2018

Closes: #565 #563 #562 #568 #571

  • Fixed namespace type def and for when a extractor function is provided
  • Removed unneeded default imports
  • Improved types for hoc's
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 23, 2018

Coverage Status

Coverage remained the same at 76.645% when pulling 61815c5 on schettino:ts into b979553 on i18next:master.

@jvgreenaway

This comment has been minimized.

Copy link

jvgreenaway commented Oct 24, 2018

These changes look good to me

@schettino

This comment has been minimized.

Copy link
Collaborator Author

schettino commented Oct 25, 2018

@jamuhl whenever it's possible, we can release this patch

@jamuhl jamuhl merged commit 19b411e into i18next:master Oct 25, 2018
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.645%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Oct 25, 2018

published in react-i18next@8.1.2

thanks a lot for the work done here

@Vrajmas

This comment has been minimized.

Copy link

Vrajmas commented Oct 25, 2018

Thanks, best regards

@MichalLytek

This comment has been minimized.

Copy link

MichalLytek commented on 61815c5 Nov 23, 2018

@schettino Shouldn't the ns prop be optional, just like in the withNamespaces?

react-i18next/index.d.ts

Lines 69 to 70 in 61815c5

export function withNamespaces(
namespace?: Namespace | NamespaceExtractor,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.