Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure withI18n hoists static members. Fixes #583. #584

Merged
merged 2 commits into from Oct 26, 2018

Conversation

@ghengeveld
Copy link
Contributor

ghengeveld commented Oct 26, 2018

Also added prettier settings to package.json so my editor would honor them.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 26, 2018

Coverage Status

Coverage increased (+0.3%) to 77.023% when pulling c075742 on ghengeveld:master into 897576d on i18next:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 26, 2018

Coverage Status

Coverage increased (+0.3%) to 77.023% when pulling c075742 on ghengeveld:master into 897576d on i18next:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 26, 2018

Coverage Status

Coverage increased (+0.3%) to 77.023% when pulling c075742 on ghengeveld:master into 897576d on i18next:master.

@jamuhl jamuhl merged commit 9d3d21b into i18next:master Oct 26, 2018
2 of 3 checks passed
2 of 3 checks passed
codeclimate 1 issue to fix
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 77.023%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Oct 26, 2018

thank you - published in react-i18next@8.3.0

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project -> there are many ways to help this project 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.