Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with react strict mode #596

Closed

Conversation

@JimmyLaurent
Copy link

JimmyLaurent commented Oct 30, 2018

Replace "componentWillReceiveProps" with "getDerivedStateFromProps" in "I18nextProvider".

Fixes: #594

…th "getDerivedStateFromProps"
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 30, 2018

Coverage Status

Coverage increased (+0.8%) to 77.814% when pulling b26a445 on JimmyLaurent:comply-to-strict-mode into f9286f6 on i18next:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 30, 2018

Coverage Status

Coverage increased (+0.8%) to 77.814% when pulling b26a445 on JimmyLaurent:comply-to-strict-mode into f9286f6 on i18next:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 30, 2018

Coverage Status

Coverage increased (+0.8%) to 77.814% when pulling a7e6ca3 on JimmyLaurent:comply-to-strict-mode into f9286f6 on i18next:master.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Oct 31, 2018

As it's only to show a warning if someone actively replaces the i18n instance - what do you think of dropping that warning? makes it simpler - and that warning i don't know how many people run into this honestly?

@JimmyLaurent

This comment has been minimized.

Copy link
Author

JimmyLaurent commented Oct 31, 2018

I totally agree, it feels like an edge case.

Do you want a new PR ?

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Oct 31, 2018

If you like and not takes to much time...else i will just remove it next time i got it open.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Nov 6, 2018

should be solved with 022b9aa

published on npm in react-i18next@8.3.6

@jamuhl jamuhl closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.