Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript tests with example usage as sanity check and hook into `test`script #655

Merged
merged 3 commits into from Jan 2, 2019

Conversation

@rosskevin
Copy link
Collaborator

rosskevin commented Dec 31, 2018

  • Add typescript usage tests for sanity and hook into ci to assist in keeping up to date.
  • Fix several errors in the type definition

Closes #654

… `test` script
@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Dec 31, 2018

Note, this test proves and fixes a few errors I am seeing downstream in my app.

ts users are likely broken due to the bad context type import until this is merged and released.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 31, 2018

Coverage Status

Coverage remained the same at 75.157% when pulling 5bcf60f on rosskevin:ts-tests into 0bf4437 on i18next:master.

rosskevin added 2 commits Dec 31, 2018
@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Dec 31, 2018

I'm still threading through my codebase and finding some fixes, let's hold this until I get a clean run locally. I'll update this issue when ready.

@rosskevin rosskevin changed the title Add typescript tests with example usage as sanity check and hook into `test`script HOLD: Add typescript tests with example usage as sanity check and hook into `test`script Dec 31, 2018
@rosskevin rosskevin changed the title HOLD: Add typescript tests with example usage as sanity check and hook into `test`script Add typescript tests with example usage as sanity check and hook into `test`script Jan 1, 2019
@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Jan 1, 2019

This PR is ready to merge.

@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Jan 1, 2019

@jamuhl if we can get this merged and released, I would appreciate it.

Incorrect types included in-repo are not easily ignored, whereas they are if they are from definitelytyped (just don't include them). This PR fixes a breaking change for ts users and should get us back to working.

@jamuhl jamuhl merged commit 146a6f6 into i18next:master Jan 2, 2019
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.157%
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jan 2, 2019

published in react-i18next@9.0.1

@VincentLanglet

This comment has been minimized.

Copy link
Contributor

VincentLanglet commented Jan 5, 2019

@rosskevin Do you have time to test also the file for hook type ?

You broke them with your PR, cf : #658

@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Jan 5, 2019

@VincentLanglet I don't use the hooks yet, but feel free to add usage tests similar to how I did the index.

@rosskevin rosskevin deleted the rosskevin:ts-tests branch Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.