Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFunction usage inside NamespacesConsumer should behave #694

Merged
merged 3 commits into from Jan 24, 2019

Conversation

@rosskevin
Copy link
Collaborator

rosskevin commented Jan 23, 2019

Closes #693 - optional props
Closes #695 - parameterized return type usage

Depends on:
i18next/i18next#1188

…with optional props

Depends on #693
@rosskevin rosskevin self-assigned this Jan 23, 2019
@rosskevin rosskevin changed the title TFunction usage inside NamespacesConsumer should behave with optional props TFunction usage inside NamespacesConsumer should behave Jan 23, 2019
@rosskevin rosskevin merged commit 7f8c36f into i18next:master Jan 24, 2019
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rosskevin rosskevin deleted the rosskevin:ts-namespacesconsumer branch Jan 24, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 24, 2019

Coverage Status

Coverage remained the same at 75.157% when pulling 8e90695 on rosskevin:ts-namespacesconsumer into dba072a on i18next:master.

@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Jan 24, 2019

@jamuhl this is ready for a patch release - finally I think we'll have stable types, sorry for all the PRs/changes and thanks for the rapid releases.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jan 24, 2019

@rosskevin published in react-i18next@9.0.8

👍thank you for investing your time into making this awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.