Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS definition for reportNS prop #699

Merged
merged 1 commit into from Jan 28, 2019

Conversation

@johnnynia
Copy link
Contributor

johnnynia commented Jan 27, 2019

The reportNS prop of I18nextProvider is missing in I18nextProviderProps.

const { children, i18n, defaultNS, reportNS } = this.props;

It was added in PR #500

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 27, 2019

Coverage Status

Coverage remained the same at 75.157% when pulling d62c894 on johnnynia:add-ts-definition-for-reportns into 5e929b5 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin Jan 27, 2019
@jamuhl jamuhl added the typescript label Jan 27, 2019
@rosskevin rosskevin merged commit aaab3b2 into i18next:master Jan 28, 2019
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.157%
Details
@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Jan 28, 2019

@jamuhl this can be a patch release

@johnnynia johnnynia deleted the johnnynia:add-ts-definition-for-reportns branch Jan 28, 2019
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Jan 30, 2019

published in react-i18next@9.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.