Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing I18nextProvider interface to typings #721

Merged
merged 4 commits into from Feb 7, 2019

Conversation

@danielsogl
Copy link
Contributor

danielsogl commented Feb 7, 2019

closes: #718

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 7, 2019

Coverage Status

Coverage remained the same at 71.264% when pulling 860d8d5 on danielsogl:patch-1 into 8dc2a10 on i18next:master.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Feb 7, 2019

@danielsogl

This comment has been minimized.

Copy link
Contributor Author

danielsogl commented Feb 7, 2019

Correct! I updated the PR

src/index.d.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

rosskevin left a comment

Please add a usage test as a new file in test/typescript

@rosskevin rosskevin added the typescript label Feb 7, 2019
@danielsogl

This comment has been minimized.

Copy link
Contributor Author

danielsogl commented Feb 7, 2019

@rosskevin I added a basic test example.

@rosskevin rosskevin merged commit 6065af7 into i18next:master Feb 7, 2019
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Feb 7, 2019

Thanks @danielsogl

@jamuhl this can be a patch release

@danielsogl danielsogl deleted the danielsogl:patch-1 branch Feb 7, 2019
@danielsogl

This comment has been minimized.

Copy link
Contributor Author

danielsogl commented Feb 7, 2019

That would be great!

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Feb 7, 2019

published in react-i18next@10.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.