Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make children optional within TransProps #728

Merged
merged 2 commits into from Feb 11, 2019

Conversation

@menthena
Copy link
Contributor

menthena commented Feb 11, 2019

Fixes #727

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 11, 2019

Coverage Status

Coverage remained the same at 90.86% when pulling 188f537 on menthena:fix/optional-children into 07c9ea9 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin Feb 11, 2019
@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Feb 11, 2019

@menthena please add another usage example that covers the case in test/typescript

@menthena menthena force-pushed the menthena:fix/optional-children branch from 2094517 to 229f34e Feb 11, 2019
@rosskevin rosskevin merged commit e110d37 into i18next:master Feb 11, 2019
0 of 2 checks passed
0 of 2 checks passed
codeclimate Code Climate is analyzing this code.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Feb 11, 2019

@jamuhl this can be a patch release

@menthena menthena deleted the menthena:fix/optional-children branch Feb 11, 2019
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Feb 11, 2019

published in react-i18next@10.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.