Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #773 by sending console as the first argument to apply #774

Merged
merged 2 commits into from Mar 8, 2019

Conversation

@skatcat31
Copy link
Contributor

skatcat31 commented Mar 8, 2019

Resolves #773

The bug was due to sending null as the context to console.warn.apply.

Fixed by passing console as the context.

skatcat31 added 2 commits Mar 8, 2019
It was called with a null which was causing a problem on IE11
Fix util.js warn function to not blow up IE11
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage remained the same at 92.893% when pulling 1f4ed84 on skatcat31:master into 69fe518 on i18next:master.

@skatcat31

This comment has been minimized.

Copy link
Contributor Author

skatcat31 commented Mar 8, 2019

Apparently code climate thinks a spread operator would be better. That may be true, but I merely wanted to fix a bug my team ran into with this package without changing the code base to heavily.

@jamuhl jamuhl merged commit 2c2fdb6 into i18next:master Mar 8, 2019
3 of 4 checks passed
3 of 4 checks passed
codeclimate 1 issue to fix
Details
ci/circleci: build Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 92.893%
Details
workflow Workflow: workflow
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Mar 8, 2019

thank you for taking the time to create the PR. Was merged and published to npm with react-i18next@10.3.1

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project -> there are many ways to help this project 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.