Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type definition for withTranslation options #821

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@maxwkh
Copy link
Contributor

maxwkh commented Apr 10, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 10, 2019

Coverage Status

Coverage remained the same at 93.534% when pulling 241bc5e on maxwkh:fix/withTranslationType into 69e4973 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin Apr 10, 2019
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Apr 10, 2019

@rosskevin guess this is correct withRef was added in https://github.com/i18next/react-i18next/pull/802/files

@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Apr 10, 2019

Thanks @maxwkh

@jamuhl this can be released as a patch

@rosskevin rosskevin merged commit 001ec04 into i18next:master Apr 10, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 93.534%
Details
workflow Workflow: workflow
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Apr 11, 2019

was published in react-i18next@10.7.0

thank you for providing this...

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project -> there are many ways to help this project 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.