Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useEffect mount/unmount usage #852

Merged
merged 1 commit into from May 16, 2019
Merged

Fix useEffect mount/unmount usage #852

merged 1 commit into from May 16, 2019

Conversation

@jigsawye
Copy link
Contributor

jigsawye commented May 16, 2019

The second params of useEffect should be [], otherwise it will be called when re-render every time.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 16, 2019

Coverage Status

Coverage decreased (-1.7%) to 91.845% when pulling 90a7e5c on jigsawye:patch-1 into 8d1e5d4 on i18next:master.

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented May 16, 2019

You're right...will be merged and published asap. Thanks for catching that one...

@jamuhl jamuhl merged commit e26547f into i18next:master May 16, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-1.7%) to 91.845%
Details
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
workflow Workflow: workflow
Details
@jigsawye jigsawye deleted the jigsawye:patch-1 branch May 16, 2019
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented May 16, 2019

was published in react-i18next@10.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.