Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use count from `values` object passed to Trans #947

Merged
merged 1 commit into from Sep 24, 2019
Merged

Conversation

@k4r1
Copy link
Contributor

k4r1 commented Sep 24, 2019

If a count is specified in the values object passed to Trans, we should use it, even if the count property is not provided.
i18next/i18next#1330

By changing the order of the construction of combinedTOpts, this should ensure that the behaviour is as expected.

If a `count` is specified in the `values` object passed to Trans, we should use it, even if the `count` property is not provided.
i18next/i18next#1330

By changing the order of the construction of `combinedTOpts`, this should ensure that the behaviour is as expected.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 24, 2019

Coverage Status

Coverage remained the same at 95.377% when pulling b58e540 on k4r1:patch-1 into 19a2a0a on i18next:master.

@jamuhl jamuhl merged commit 37408e6 into i18next:master Sep 24, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 95.377%
Details
workflow Workflow: workflow
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Sep 24, 2019

published in react-i18next@10.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.