Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors #966

Merged
merged 5 commits into from Oct 21, 2019
Merged

Fix linter errors #966

merged 5 commits into from Oct 21, 2019

Conversation

@tisoap
Copy link
Contributor

tisoap commented Oct 12, 2019

While reading the source code, I noticed the project still had some linter warnings showing up, so I decided to address them before anything. The list of changes:

  • Added /test folder to test:lint script
  • Fixed all errors and warnings produced by npm run test:lint
  • Disabled react/jsx-props-no-spreading rule, since it is being used by withTranslation.js
  • Updated eslint dependencies, which in turn removed a linter warning from useTranslation.loading.spec.js
tisoap added 5 commits Oct 12, 2019
This also removes react/state-in-constructor rule, making
useTranslation.loading.spec.js file valid
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 12, 2019

Coverage Status

Coverage increased (+0.02%) to 95.663% when pulling d2d404b on tisoap:fix/linter-errors into 05b3e4d on i18next:master.

@jamuhl jamuhl merged commit 2d67848 into i18next:master Oct 21, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate 14 fixed issues
Details
coverage/coveralls Coverage increased (+0.02%) to 95.663%
Details
workflow Workflow: workflow
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Oct 21, 2019

thank you

@tisoap tisoap deleted the tisoap:fix/linter-errors branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.