Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t function to TransProps types #969

Merged
merged 2 commits into from Oct 23, 2019
Merged

Conversation

@valgussev
Copy link
Contributor

valgussev commented Oct 18, 2019

It seems t function is currently missing from types, let's add it back

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 18, 2019

Coverage Status

Coverage remained the same at 95.642% when pulling 0c874c1 on valerii-cognite:transprops-t into 05b3e4d on i18next:master.

@jamuhl jamuhl requested a review from rosskevin Oct 18, 2019
Copy link
Collaborator

rosskevin left a comment

Please add a usage test in test/typescript to prevent future regressions

@valgussev

This comment has been minimized.

Copy link
Contributor Author

valgussev commented Oct 21, 2019

@rosskevin added

Copy link
Collaborator

rosskevin left a comment

Perfect, thank you @valerii-cognite

@rosskevin rosskevin merged commit 8d84b7d into i18next:master Oct 23, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 95.642%
Details
workflow Workflow: workflow
Details
@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Oct 23, 2019

@jamuhl this can be a patch release

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Oct 24, 2019

published in react-i18next@10.13.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.