Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update `rollup.config.js` for IE11 Transpilations #988

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@baublet
Copy link
Contributor

baublet commented Nov 6, 2019

Rollup doesn't set targets for browsers.

This commit addresses: #915

My question: is this an appropriate solution? My knowledge of the various JS module types isn't up to the point where I can say definitively one way or the other.

Rollup doesn't set targets for browsers. This commit addresses: #915
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 6, 2019

Coverage Status

Coverage remained the same at 95.444% when pulling bce75b6 on baublet:ie-11-fix into c08282e on i18next:master.

@baublet

This comment has been minimized.

Copy link
Contributor Author

baublet commented Nov 6, 2019

I tested this locally with IE11 and can confirm that targeting IE11 here does work, specifically because it transpiles ES6 classes into ES5.

@jamuhl jamuhl merged commit b857791 into i18next:master Nov 7, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 95.444%
Details
workflow Workflow: workflow
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Nov 7, 2019

published in react-i18next@11.1.0

@jamuhl jamuhl mentioned this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.