Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass forwardedRef to children if options.withRef is false #999

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@emroussel
Copy link
Contributor

emroussel commented Nov 18, 2019

forwardedRef was always passed down to its children in #992, but as pointed in the comments, it should only be passed down if options.withRef is false (if it is true, we want to pass the ref as ref and remove forwardedRef from props) and if forwardedRef is defined.

@emroussel emroussel changed the title Only pass forwardedRef to children if options.withRefis false Only pass forwardedRef to children if options.withRef is false Nov 18, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 18, 2019

Coverage Status

Coverage decreased (-0.2%) to 95.238% when pulling 90f446b on emroussel:withTranslation-forwardedRef into 0c589dd on i18next:master.

@jamuhl jamuhl merged commit d77f92f into i18next:master Nov 19, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.2%) to 95.238%
Details
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
workflow Workflow: workflow
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Nov 19, 2019

thank you - this fix was published in react-i18next@11.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.