Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow key_cb configuration #7

Merged
merged 4 commits into from Jan 14, 2020

Conversation

@piacsek
Copy link
Contributor

piacsek commented Jan 8, 2020

Proposal

This PR aims to make key_cb option configurable.

Motivation

This has been done so we could store our private key in an environment variable, avoiding the hassle of setting up a file storage just for this file.

@tlux

This comment has been minimized.

Copy link
Contributor

tlux commented Jan 8, 2020

Hello, @piacsek! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

def new(%__MODULE__{} = config), do: config
def new(opts), do: struct!(__MODULE__, opts)
def new(%__MODULE__{} = config), do: config |> set_key_cb()
def new(opts), do: struct!(__MODULE__, opts) |> set_key_cb()

This comment has been minimized.

Copy link
@tlux

tlux Jan 8, 2020

Contributor

Pipe chain should start with a raw value.

@piacsek piacsek requested a review from tlux Jan 8, 2020
@piacsek piacsek changed the title Allow key provider option Allow key_cb option Jan 8, 2020
@piacsek piacsek changed the title Allow key_cb option Allow key_cb configuration Jan 8, 2020
@tlux tlux merged commit 4a3d84f into i22-digitalagentur:master Jan 14, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 93.401%
Details
sourcelevel SourceLevel did not find any new or fixed issues.
Details
@tlux

This comment has been minimized.

Copy link
Contributor

tlux commented Jan 14, 2020

Thanks for your contribution ❤️

@piacsek

This comment has been minimized.

Copy link
Contributor Author

piacsek commented Jan 14, 2020

Thanks for your contribution ❤️

No prob, mate! Hope to keep contributing. 😸

@piacsek piacsek deleted the sumup-bank:allow-key-provider-option branch Jan 14, 2020
@piacsek piacsek restored the sumup-bank:allow-key-provider-option branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.