Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmipp_transform_add_noise and aligned particles #152

Closed
rmarabini opened this issue May 24, 2019 · 2 comments
Closed

xmipp_transform_add_noise and aligned particles #152

rmarabini opened this issue May 24, 2019 · 2 comments
Assignees

Comments

@rmarabini
Copy link
Contributor

rmarabini commented May 24, 2019

hi,

The protocol xmippAddNoiseParticles is inconsistent when using as input aligned particles.

xmippAddNoiseParticles read the particle and if there is a transformation matrix it applies the in-plane rotation before saving the new image. Finally, the protocol assigns to the new image the same transformation matrix than had the input image. The correct way to do this would be either

  1. Do NOT apply the inplane rotation to the new image and store the input image transformation (my favorite solution)
  2. Apply the in-plane rotation and store a modified transformation matrix. This matrix would be the product of the original transformation matrix by the inverse of the matrix created by euler angles (0,0,injplanerotation)
@DStrelak
Copy link
Collaborator

I would also go for 1.

@Vilax Vilax self-assigned this Jan 31, 2022
@cossorzano
Copy link
Contributor

It does not behave like this anymore. It was already solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants