enhancement: move compatibility functions (e.g. our memmem) into separate files, use AC_REPLACE_FUNCS #2610

Open
stapelberg opened this Issue Dec 19, 2016 · 0 comments

Projects

None yet

3 participants

@stapelberg
Member

Currently, we occasionally provide implementations of functions which aren’t present on some platforms.

The only instance I can find is https://github.com/i3/i3/blob/8d739b7fe15fd351b5d703f922db01be46699a92/src/util.c#L283-L317. If there are others, please point me to them :).

We should consider moving these out into a standalone source file and then using autoconf’s AC_REPLACE_FUNCS macro to compile and link this file on systems where the function is detected as missing.

@i3bot i3bot added the enhancement label Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment