i3bar leaks memory when trayclients disappear #2619

Closed
Airblader opened this Issue Dec 31, 2016 · 0 comments

Projects

None yet

1 participant

@Airblader
Member

In handle_destroy_notify we call

            DLOG("Removing tray client with window ID %08x\n", event->window);
            TAILQ_REMOVE(walk->trayclients, trayclient, tailq);

but never actually free trayclient which has been allocated before:

            trayclient *tc = smalloc(sizeof(trayclient));
            tc->win = client;
            tc->xe_version = xe_version;
            tc->mapped = false;
            TAILQ_INSERT_TAIL(output->trayclients, tc, tailq);

i3 4.13

@Airblader Airblader added a commit to Airblader/i3-original that referenced this issue Jan 13, 2017
@Airblader Airblader Free trayclient when removing it.
fixes #2619
065302b
@Airblader Airblader added a commit to Airblader/i3-original that referenced this issue Jan 13, 2017
@Airblader Airblader Free trayclient when removing it.
fixes #2619
d4cd23d
@Airblader Airblader added a commit to Airblader/i3-original that referenced this issue Jan 13, 2017
@Airblader Airblader Free trayclient when removing it.
fixes #2619
f8dc34f
@stapelberg stapelberg closed this in #2632 Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment