Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Enhancement] Resize tiled windows by px instead of ppt #3239
I've found myself frustrated by the inability to exactly resize windows in tiles, especially when I'm resizing a terminal that I want to get to a specific text width. With the mouse, I can do pixel-perfect resizing, but otherwise I'm stuck with ppt, and the smallest percentage point is 1, since floats aren't supported, so there's effectively no way to resize with the keyboard at that level of precision.
I have a PR almost ready with this feature; I'm ironing out the kinks now and working on test cases. I've been running it on my development workstation for a while now.
The old docs say:
And I would update them to say:
If a ppt value is specified, it will be preferred to the px value for tiling containers only. So this change is somewhat backwards compatible, in that configurations that specify both px and ppt would continue to behave the same way.
An alternative solution would be to allow fractional ppt value (I had a PR for this ready as well, but it was uglier and harder to control).
Okay, but I don't have any testcases and have not yet run the test suite against the change, but with those caveats I'll start the PR.
By "somewhat" I mean that if a configuration specifies only a px in a resize, then the px will now be used instead of defaulting to 10ppt. (EDIT: I mis-wrote this as being the other way around)
That's fine, PRs can be updated. :-) We generally recommend first discussing, then implementing in case the feature is not accepted. Since you have written the code already, however, there's no reason not to look at it as well.
Travis will do this for you now, too. ;-)
I think that's an acceptable »breaking« change.