New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap crash with workspace_layout stacking #3280

Closed
orestisf1993 opened this Issue May 6, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@orestisf1993
Member

orestisf1993 commented May 6, 2018

Credits to @nejni-marji

Output of i3 --moreversion 2>&- || i3 --version:
Binary i3 version: 4.15-145-g1cdb1ab7 (2018-05-05, branch "next") © 2009 Michael Stapelberg and contributors

URL to a logfile as per https://i3wm.org/docs/debugging.html:
https://logs.i3wm.org/logs/5731791428124672.bz2

What I did:
Use default config file, append workspace_layout stacking. Open 3 windows and:

  • move right
  • focus left
  • focus parent, mark a
  • focus right
  • swap with mark a

What I saw:
backtace: https://bpaste.net/raw/513fcacfa0dd

@i3bot i3bot added the 4.15 label May 6, 2018

orestisf1993 added a commit to orestisf1993/i3 that referenced this issue Oct 10, 2018

Rewrite con_swap to work only with queue operations
Benefits are that we don't open a fake container and don't call many
complicated functions that can lead to redraws (x_push_changes calls) as
discussed in i3#2954.

Fixes i3#2810:
Windows exchange floating mode & window rects.
Swap will still not work with CT_FLOATING_CONs but this doesn't make
much sense.

Fixes i3#3280:
The behaviour is not very user friendly but swap behaves exactly as it
should. The rest is a tree_flatten issue. Attached pictures in i3#2954.

orestisf1993 added a commit to orestisf1993/i3 that referenced this issue Oct 10, 2018

Rewrite con_swap to work only with queue operations
Benefits are that we don't open a fake container and don't call many
complicated functions that can lead to redraws (x_push_changes calls) as
discussed in i3#2954.

Fixes i3#2810:
Windows exchange floating mode & window rects.
Swap will still not work with CT_FLOATING_CONs but this doesn't make
much sense.

Fixes i3#3280:
The behaviour is not very user friendly but swap behaves exactly as it
should. The rest is a tree_flatten issue. Attached pictures in i3#2954.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment