New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancehement: Render left and right borders of titles in stacked mode #3412

Open
aksel opened this Issue Sep 17, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@aksel

aksel commented Sep 17, 2018

I'm submitting a…

[ ] Bug
[x] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

I'm using pixel borders.

Stacking vs tabbed mode renders the title borders of the focused container in different manners, and inconsistently with regards to child borders.

These two images show the differences. Tabbed render a border all around the title, whereas stacked stop at the child border.

In this image, I have increased the border to exaggerate the effect. You can see, in addition to the left and right borders of the stacked title missing, the lower horizontal border stops at the child border, with 1 pixel missing at the edges.

Current, tabbed: 

╔══════╗──────┬──────┐
║ tab1 ║ tab2 │ tab3 │
╠══════╝─────────────╖
║                    ║
╚════════════════════╝

Current, stacked:
┌────────────────────┐   ┌────────────────────┐
│ stack1             │   │ stack1             │
├────────────────────┤   ├════════════════════┤
│ stack2             │   │ stack 2 (focused)  │
├════════════════════┤   ├════════════════════┤
│ stack 3 (focused)  │   │ stack3             │
├════════════════════┤   ╓────────────────────╖
║                    ║   ║                    ║
║                    ║   ║                    ║
╚════════════════════╝   ╚════════════════════╝

Expected Behavior

Desired, stacked:
┌────────────────────┐   ┌────────────────────┐
│ stack1             │   │ stack1             │
├────────────────────┤   ╔════════════════════╗
│ stack2             │   ║ stack 2 (focused)  ║
╔════════════════════╗   ╚════════════════════╝
║ stack 3 (focused)  ║   │ stack3             │
╠════════════════════╣   ╓────────────────────╖
║                    ║   ║                    ║
║                    ║   ║                    ║
╚════════════════════╝   ╚════════════════════╝

Borders should be rendered all around around the focused title.

Environment

Output of i3 --moreversion 2>&-:

i3 version: 

Binary i3 version:  4.15.0.1 (03-13-2018) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.15.0.1 (03-13-2018) (pid 601)bort…)
Loaded i3 config: /home/aksel/.config/i3/config (Last modified: mán 17 sep 2018 22:25:17 CEST, 1641 seconds ago)

The i3 binary you just called: /usr/bin/i3
The i3 binary you are running: i3

Note, I'm using i3-gaps, but I don't think this issue is related to gaps.

- Linux Distribution & Version: Arch Linux, 4.18.6
- Are you using a compositor (e.g., xcompmgr or compton): No.

@i3bot i3bot added the enhancement label Sep 17, 2018

@aksel aksel changed the title from Render left and right borders of titles in stacked mode to Enhancehement: Render left and right borders of titles in stacked mode Sep 17, 2018

@Airblader

This comment has been minimized.

Show comment
Hide comment
@Airblader

Airblader Sep 19, 2018

Member

Makes sense to me.

Member

Airblader commented Sep 19, 2018

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment