Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a i3-input exit status indicating whether a command was executed #3705

Open
rittelle opened this issue May 21, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@rittelle
Copy link

commented May 21, 2019

I'm submitting a…

[ ] Bug
[x] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

Currently i3-input returns 0 whenever no error occured in the program itself.

Desired Behavior

i3-input could return 0 when the specified command was executed successfully and other values (e.g. 1 and 2) when the user canceled the process (by using the escape key) or the specified command failed respectively.

Environment

Output of i3 --moreversion 2>&-:

Binary i3 version:  4.16.1 (2019-01-27) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.16.1 (2019-01-27) (pid 1660)abort…)
Loaded i3 config: /home/rittelle/.config/i3/config (Last modified: Sat 18 May 2019 08:06:23 AM CEST, 268412 seconds ago)

The i3 binary you just called: /nix/store/mf89f7cf3nnvzrv4ybyym476v8w02z68-i3-gaps-4.16.1/bin/i3
The i3 binary you are running: /nix/store/mf89f7cf3nnvzrv4ybyym476v8w02z68-i3-gaps-4.16.1/bin/i3

Yes, I‘m using gaps, but skimming over the i3-input code on the next branch, the current behavior seems to be the same.

@Airblader

This comment has been minimized.

Copy link
Member

commented May 21, 2019

SGTM, PRs welcome

@rittelle

This comment has been minimized.

Copy link
Author

commented May 21, 2019

It doesn‘t sound too complicated, if I find the time later today, I‘ll see what I can do.

@zarszz

This comment has been minimized.

Copy link

commented May 23, 2019

interest thing

@rittelle

This comment has been minimized.

Copy link
Author

commented Jun 2, 2019

It could take some time until I get to work on this, but it is not forgotten :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.