Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen criteria #3714

Open
emersion opened this issue Jun 8, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@emersion
Copy link

commented Jun 8, 2019

I'm submitting a…

[ ] Bug
[x] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

N/A

Desired Behavior

Would a fullscreen criteria be welcome? Something along the lines of:

for_window [fullscreen] <command>

Environment

i3 version: HEAD

@Airblader

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Instead of "should we add feature X" we should ask what the use-case is you are trying to solve and then we can discuss whether this would be a good solution. So what would this be used for?

@schelmo

This comment has been minimized.

Copy link

commented Jun 11, 2019

my use case would be to control some things in fullscreen windows only with a wireless mouse
for example:

bindsym --whole-window --border button4 [con_id="__focused__" fullscreen] exec pactl set-sink-volume @DEFAULT_SINK@ +5%
bindsym --whole-window --border button5 [con_id="__focused__" fullscreen] exec pactl set-sink-volume @DEFAULT_SINK@ -5%
bindsym --whole-window --border button1+button2 [con_id="__focused__" fullscreen] fullscreen disable
@Airblader

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Are you sure this does what you want? It would bind those buttons for all windows (removing their primary function, which is probably scroll) and then just do nothing on most windows. That's not the same as overriding function only on fullscreen windows.

In particular the last example doesn't require the criterion at all as for non-fullscreened windows it would become a no-op.

@Airblader

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Also note that this can be implemented fairly easily by listening for window::fullscreen_mode events, setting a mark on the fullscreen window and matching using con_mark.

@schelmo

This comment has been minimized.

Copy link

commented Jun 11, 2019

Are you sure this does what you want? It would bind those buttons for all windows (removing their primary function, which is probably scroll) and then just do nothing on most windows.

nope that is not what i want :)

Also note that this can be implemented fairly easily by listening for window::fullscreen_mode events, setting a mark on the fullscreen window and matching using con_mark.

sounds good. will try that

OT: is there a way to bind only for windows with a special criterion?
or maybe i go with a mode

@Airblader

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

No, there is no way to do that in i3.

I still wonder if the criterion could be useful in other cases. I'd like to leave this issue open until we have one. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.