Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave Fullscreen Temporary on popup #3805

Open
fcladera opened this issue Sep 27, 2019 · 5 comments

Comments

@fcladera
Copy link

commented Sep 27, 2019

I'm submitting a…

[ ] Bug
[x] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

When there is a popup, current options quit fullscreen (or ignore the popup).

Desired Behavior

It would be good to go back to the fullscreen mode after the popup has been solved. I'll submit a PR if there is enough momentum.

Environment

Output of i3 --moreversion 2>&-:

i3 version: 

Binary i3 version:  4.17.1 (2019-08-30) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.17.1 (2019-08-30) (pid 2597)abort…)
Loaded i3 config: /home/fclad/.i3/config (Last modified: Wed 04 Sep 2019 03:05:46 PM EDT, 1973955 seconds ago)

The i3 binary you just called: /usr/bin/i3
The i3 binary you are running: i3
- Linux Distribution & Version: Arch Linux
- Are you using a compositor (e.g., xcompmgr or compton): compton
@i3bot i3bot added the enhancement label Sep 27, 2019
@Airblader

This comment has been minimized.

Copy link
Member

commented Sep 28, 2019

For my understanding, do you already have the patch ready or would you simply be willing to start working on this if approved?

@fcladera

This comment has been minimized.

Copy link
Author

commented Sep 30, 2019

I have started doing something, but it is far from complete.I just wanted to know if the feature is useful or it is a waste of time to prepare a PR on this. Thanks!

@orestisfl

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

First of all, when popup_during_fullscreen smart is set popups do not leave fullscreen.

So, this issue is only about popup_during_fullscreen leave_fullscreen. Should the proposed new behavior optional or the default?

@Airblader Airblader added the 4.17 label Oct 6, 2019
@Airblader

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

The reason I'm not sure about adding this is that it can lead to pretty confusing behavior. If fullscreen is left and the user does a bunch of things before actually closing that window, it is awkward that suddenly some window regains fullscreen status "out of nowhere". On the other hand I also see the usefulness of this behavior, in fact personally I have a script which does basically exactly this for when I open some throw-away floating terminal.

@fcladera

This comment has been minimized.

Copy link
Author

commented Oct 7, 2019

Maybe setting a timer would help? My first use case was password popups, which get resolved pretty quickly but afterwards one has to explicitly make the window that triggered the popup fullscreen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.