New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to clang-format-3.8 #2547

Merged
merged 1 commit into from Nov 8, 2016

Conversation

Projects
None yet
2 participants
@stapelberg
Member

stapelberg commented Nov 8, 2016

https://llvm.org/bugs/show_bug.cgi?id=30353 was filed for the unintended
line break between in e.g. “TAILQ_ENTRY(foo)\nbar;”.

Until that’s fixed or a workaround is known, we’ll live with line
breaks. To make it a bit easier for readers to see what’s going on, I
added extra line breaks around each such struct member/variable
definition, so that they at least visually are a single unit.

fixes #2174

switch to clang-format-3.8
https://llvm.org/bugs/show_bug.cgi?id=30353 was filed for the unintended
line break between in e.g. “TAILQ_ENTRY(foo)\nbar;”.

Until that’s fixed or a workaround is known, we’ll live with line
breaks. To make it a bit easier for readers to see what’s going on, I
added extra line breaks around each such struct member/variable
definition, so that they at least visually are a single unit.

fixes #2174
@Airblader

I'd very much love to argue about this, but working tests outweigh the terrible formatting by far.

@stapelberg stapelberg merged commit fff3f79 into i3:next Nov 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stapelberg stapelberg deleted the stapelberg:clangformat branch Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment