New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not check for NULL in FREE macro #3058

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
2 participants
@d-e-s-o
Contributor

d-e-s-o commented Nov 24, 2017

free(3) is safe to invoke on a NULL pointer, in which case no action is
taken. This change adjusts the FREE macros to omit this unnecessary
check.

do not check for NULL in FREE macro
free(3) is safe to invoke on a NULL pointer, in which case no action is
taken. This change adjusts the FREE macros to omit this unnecessary
check.
@d-e-s-o

This comment has been minimized.

Show comment
Hide comment
@d-e-s-o

d-e-s-o Nov 29, 2017

Contributor

Anybody? Trivial and non-invasive.

Contributor

d-e-s-o commented Nov 29, 2017

Anybody? Trivial and non-invasive.

@Airblader

I can't see anything wrong with this either. I doubt anyone is compiling i3 with a several decades old compiler for super specific platforms.

@Airblader Airblader merged commit f6f198c into i3:next Nov 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@d-e-s-o d-e-s-o deleted the d-e-s-o:fix-FREE branch Dec 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment