Make window icons follow title alignment #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airblader
reviewed
Sep 8, 2021
orestisfl
force-pushed
the
icons-title-align
branch
from
9f2918e
to
581c06b
Compare
Airblader
reviewed
Sep 9, 2021
Fixes i3#4464. Inspired by changes from i3#4453 but I didn't end up using the original code. For ALIGN_LEFT and ALIGN_CENTER icon offset is calculated first and then title offset is based on that. For ALIGN_RIGHT title offset is calculated first but we make sure that the icon fits in the window. Additionally, icons will now hide if there is not enough space to render them + their padding. Realistically, this won't happen in normal usecases. Effectively, icons have higher precedence over text: draw_util_text will hide text when it exceeds the max width and the code takes this into consideration. Icons will only hide when they can't fit at all, not in order to assure that the text can be displayed fully.
orestisfl
force-pushed
the
icons-title-align
branch
from
581c06b
to
cc44d9a
Compare
Airblader
approved these changes
Sep 9, 2021
|
I did, when it was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4464
Related to #4453
See commit message