Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to boost audio. #71

Merged
merged 1 commit into from Jun 24, 2013
Merged

Adds ability to boost audio. #71

merged 1 commit into from Jun 24, 2013

Conversation

xzKinGzxBuRnzx
Copy link
Contributor

This was quite simple and does work! #14

@roidy
Copy link
Collaborator

roidy commented Jun 24, 2013

Great, but why did you pick those values, 100, 175, 225, 300. That seems to be a non-linear ramp, wouldn't a more linear set of values like 100, 150, 200, 250, 300 be better? Plus does the audio really need boosting 300 percent?

@xzKinGzxBuRnzx
Copy link
Contributor Author

I got the values from the Roku client source code. https://github.com/plexinc/roku-client-public/blob/27bd31fa2fb5a6f8fee9f3f2ef2ef3568e13f913/Plex/source/PreferenceScreen.brs

I think it doesn't always need boosted. There are some videos I try watching though and the audio is so awful I'm forced to crank my TV to the max, which is bad should anything loud happen. This is rare but I think its a wise choice to provide the option for those of us that don't have / care about 5.1 or greater audio.

@roidy
Copy link
Collaborator

roidy commented Jun 24, 2013

Yep, I fully agree audio boost does need adding, I was just questioning the values, I would of thought a more linear progression would of been better. No matter I'll merge the code, the values can always be tweaked later, thanks :)

roidy added a commit that referenced this pull request Jun 24, 2013
Adds ability to boost audio.
@roidy roidy merged commit e8c8b49 into iBaa:XML_templates Jun 24, 2013
@elan
Copy link
Contributor

elan commented Jun 24, 2013

Consistency between the clients as far as values is definitely considered a good thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants