New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SmaliDebugging #1061

Closed
iBotPeaches opened this Issue Oct 14, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@iBotPeaches
Owner

iBotPeaches commented Oct 14, 2015

Continuing to support this feature, with the means of Smalidea out seem like a waste of resources at this point. Four years ago, there was no better option to debug closed source applications.

Now with https://github.com/JesusFreke/smali/wiki/smalidea - and IntelliJ, the stress/work that apktool had to do is resolved with a simple decode from baksmali, and one can experience 10x the features that smali-debugging (apktool version) had.

Pros

  1. Less code to maintain
  2. Removal of smali into a maven dependency
  3. Easier updates of smali project
  4. More focus on resources (with the increase of resource obfuscation) is big plus.

Cons

  1. We lose SmaliDebugging (our version), which is hit/miss in terms of IDE and support these days.
  2. Those who still depend on this feature will have to transition to smali idea plugin.
  3. smali-idea is in Alpha still

If we decide to process the removal, the options would be.

  1. Remove all smali patches.
  2. Remove smali submodule
  3. Add smali dependency
  4. Remove all apktool related smali debug files
  5. Ensure apktool builds with smali as dependency vs submodule

Opinions? @brutall ? More or less want to spark a discussion here.

@iBotPeaches iBotPeaches added the Feature label Oct 14, 2015

@rover12421

This comment has been minimized.

Show comment
Hide comment
@rover12421

rover12421 Oct 15, 2015

Contributor

Support!

Contributor

rover12421 commented Oct 15, 2015

Support!

@sheep0704

This comment has been minimized.

Show comment
Hide comment

···

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment