New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create --original feature using zip library #118

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 8 created by Brut.alll on 2010-03-17T10:23:40.000Z:

Then we will be able to add some build-sign-install-run combo commands.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by Brut.alll on 2011-01-25T21:16:54.000Z:

Issue 129 has been merged into this issue.

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by Brut.alll on 2011-01-25T21:16:54.000Z:

Issue 129 has been merged into this issue.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by rickmartensen on 2011-07-05T19:09:19.000Z:

want this too :)

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by rickmartensen on 2011-07-05T19:09:19.000Z:

want this too :)

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #3 originally posted by Brut.alll on 2011-11-05T19:01:12.000Z:

<empty>

Owner

iBotPeaches commented Mar 18, 2015

Comment #3 originally posted by Brut.alll on 2011-11-05T19:01:12.000Z:

<empty>

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #4 originally posted by frischmilch on 2012-01-25T03:56:04.000Z:

yes this would be great. I compiled and signed an apk with adobe's viewer builder (for their DPS solution) and wanted to change values in the manifest and rebuild again (certificates are installed on my machines and p12 files are heady"

Owner

iBotPeaches commented Mar 18, 2015

Comment #4 originally posted by frischmilch on 2012-01-25T03:56:04.000Z:

yes this would be great. I compiled and signed an apk with adobe's viewer builder (for their DPS solution) and wanted to change values in the manifest and rebuild again (certificates are installed on my machines and p12 files are heady"

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #5 originally posted by connor.tumbleson on 2012-12-30T03:18:25.000Z:

I've wanted to do this as well, but then comes the problem of system app vs non-system app, which then brings me back to my in-progress feature of injecting changed resources back into the original apk (thus retaining the signature), except w/ new data.

This method would only really work with non-system apps. Unless the APK was installed via ROM instead of adb push. Maybe drop in favour of --original

Owner

iBotPeaches commented Mar 18, 2015

Comment #5 originally posted by connor.tumbleson on 2012-12-30T03:18:25.000Z:

I've wanted to do this as well, but then comes the problem of system app vs non-system app, which then brings me back to my in-progress feature of injecting changed resources back into the original apk (thus retaining the signature), except w/ new data.

This method would only really work with non-system apps. Unless the APK was installed via ROM instead of adb push. Maybe drop in favour of --original

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #6 originally posted by connor.tumbleson on 2013-03-07T13:44:07.000Z:

Started to use aapt in order to iterate through all the files in the APK. Removing them one by one and then inserting the new file (ex classes.dex, resources.arsc, all binary data). In order to prevent the need of a zip reader.

This worked great until I started using APKs that had unknown resources and a non-standard build procedure. AAPT wouldn't allow data insertion into an APK that it didn't "perceive" as a true APK. If I shipped with this feature and the increasing rate that APKs are doing this process, the feature would be useless.

Thats why we have to use an ZIP library and manage / talk to the APK via that. We could modify aapt to allow this, but aapt is platform dependent and it would be difficult to force people to use ours when they already have difficulties using the most up to date aapt (some users still reporting bugs because they are using a 2 year old aapt).

The last time I tried this, I had very good progress except for the fact that all files were being duplicated in the ZIP instead of replaced.

Owner

iBotPeaches commented Mar 18, 2015

Comment #6 originally posted by connor.tumbleson on 2013-03-07T13:44:07.000Z:

Started to use aapt in order to iterate through all the files in the APK. Removing them one by one and then inserting the new file (ex classes.dex, resources.arsc, all binary data). In order to prevent the need of a zip reader.

This worked great until I started using APKs that had unknown resources and a non-standard build procedure. AAPT wouldn't allow data insertion into an APK that it didn't "perceive" as a true APK. If I shipped with this feature and the increasing rate that APKs are doing this process, the feature would be useless.

Thats why we have to use an ZIP library and manage / talk to the APK via that. We could modify aapt to allow this, but aapt is platform dependent and it would be difficult to force people to use ours when they already have difficulties using the most up to date aapt (some users still reporting bugs because they are using a 2 year old aapt).

The last time I tried this, I had very good progress except for the fact that all files were being duplicated in the ZIP instead of replaced.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #7 originally posted by connor.tumbleson on 2013-03-20T11:41:45.000Z:

Fixed in 2.0wip

All credit to M1cha

Owner

iBotPeaches commented Mar 18, 2015

Comment #7 originally posted by connor.tumbleson on 2013-03-20T11:41:45.000Z:

Fixed in 2.0wip

All credit to M1cha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment