New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getters and setters for private fields/methods changed from access$ to -get / -wrap #1354

Open
jtothe4n opened this Issue Oct 31, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@jtothe4n

jtothe4n commented Oct 31, 2016

I noticed that on Android N, the naming changed.
Tried it on an HTC10 build and also on an CM14, both have the new naming.

Tried to compile an own apk then with SDK25 but still get the old access$ naming.

Any idea how to get the new naming to work on own compiled apks?
Or is it possible to add a switch to get the old naming back?

@xpirt

This comment has been minimized.

Show comment
Hide comment
@xpirt

xpirt Oct 31, 2016

Contributor

Don't think it's related to android sdk, LG decompiled apps have -get(), -wrap() and -set() methods since api 23.

Wondering too how that can be achieved though..

Contributor

xpirt commented Oct 31, 2016

Don't think it's related to android sdk, LG decompiled apps have -get(), -wrap() and -set() methods since api 23.

Wondering too how that can be achieved though..

@jtothe4n

This comment has been minimized.

Show comment
Hide comment
@jtothe4n

jtothe4n Nov 1, 2016

@xpirt Do you always rename it to the new naming or use the old "access$" onces?
Should still work I assume.

jtothe4n commented Nov 1, 2016

@xpirt Do you always rename it to the new naming or use the old "access$" onces?
Should still work I assume.

@xpirt

This comment has been minimized.

Show comment
Hide comment
@xpirt

xpirt Nov 1, 2016

Contributor

I usually leave them as they are, but yes renaming them makes it more readable and they don't break anything.

Contributor

xpirt commented Nov 1, 2016

I usually leave them as they are, but yes renaming them makes it more readable and they don't break anything.

@xpirt

This comment has been minimized.

Show comment
Hide comment
@xpirt

xpirt Dec 1, 2016

Contributor

It seems that there's a new nice toolchain which generates those new getters/setters, it is called Jack.

Jack is a new Android toolchain that compiles Java source into Android dex bytecode. It replaces the previous Android toolchain, which consists of multiple tools, such as javac, ProGuard, jarjar, and dx.

https://source.android.com/source/jack.html

Contributor

xpirt commented Dec 1, 2016

It seems that there's a new nice toolchain which generates those new getters/setters, it is called Jack.

Jack is a new Android toolchain that compiles Java source into Android dex bytecode. It replaces the previous Android toolchain, which consists of multiple tools, such as javac, ProGuard, jarjar, and dx.

https://source.android.com/source/jack.html

@jtothe4n

This comment has been minimized.

Show comment
Hide comment
@jtothe4n

jtothe4n Dec 1, 2016

yepp @JesusFreke told me that yesterday too. JesusFreke/smali#475

jtothe4n commented Dec 1, 2016

yepp @JesusFreke told me that yesterday too. JesusFreke/smali#475

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Dec 1, 2016

Owner

Thanks for the research on this. I'll mark as upstream since it appears this is something smali will need to patch.

Owner

iBotPeaches commented Dec 1, 2016

Thanks for the research on this. I'll mark as upstream since it appears this is something smali will need to patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment