New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Oreo Changes #1594

Closed
iBotPeaches opened this Issue Aug 22, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@iBotPeaches
Owner

iBotPeaches commented Aug 22, 2017

The reserved res0 & res1 got tweaked in favor of some spare entry

   enum {
        // If set, the entry is sparse, and encodes both the entry ID and offset into each entry,
        // and a binary search is used to find the key. Only available on platforms >= O.
        // Mark any types that use this with a v26 qualifier to prevent runtime issues on older
        // platforms.
        FLAG_SPARSE = 0x01,
    };
    uint8_t flags;

    // Must be 0.
uint16_t reserved;

Color Gamut cleaned up - aosp-mirror/platform_frameworks_base@e84ad49

@iBotPeaches iBotPeaches added this to the 2.2.5 milestone Aug 22, 2017

@iBotPeaches iBotPeaches self-assigned this Aug 22, 2017

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Aug 23, 2017

Owner

I have upgraded our flavored version of AAPT to (android_8.0.0_r4), all patches applied - https://github.com/iBotPeaches/platform_frameworks_base/tree/apktool_8.0.0

Will work on builds of aapt and then onward to Apktool qualifier changes.

Owner

iBotPeaches commented Aug 23, 2017

I have upgraded our flavored version of AAPT to (android_8.0.0_r4), all patches applied - https://github.com/iBotPeaches/platform_frameworks_base/tree/apktool_8.0.0

Will work on builds of aapt and then onward to Apktool qualifier changes.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Aug 23, 2017

Owner

Linux (32/64) aapt builds are working fine. After confirmed working with our manual patches and new qualifiers, I will build Windows/Mac versions.

Owner

iBotPeaches commented Aug 23, 2017

Linux (32/64) aapt builds are working fine. After confirmed working with our manual patches and new qualifiers, I will build Windows/Mac versions.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Aug 23, 2017

Owner

Initial commit(s) + support for mac os x. A few more platforms to add and a bunch more tests. It seems if you request qualifier vrheadset, aapt knows that won't be used in less than API 26, so it drops it.

If you include the -v26 qualifier, it passes. Note this is all moot in Android Studio, because it does it behind the scene implicitly versioning things via aapt.

Owner

iBotPeaches commented Aug 23, 2017

Initial commit(s) + support for mac os x. A few more platforms to add and a bunch more tests. It seems if you request qualifier vrheadset, aapt knows that won't be used in less than API 26, so it drops it.

If you include the -v26 qualifier, it passes. Note this is all moot in Android Studio, because it does it behind the scene implicitly versioning things via aapt.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Aug 24, 2017

Owner

Linux is failing due to libc++ no longer being static compiled. Time to dig into the mess of AOSP to figure out why this is the case.

Owner

iBotPeaches commented Aug 24, 2017

Linux is failing due to libc++ no longer being static compiled. Time to dig into the mess of AOSP to figure out why this is the case.

iBotPeaches added a commit that referenced this issue Aug 24, 2017

Drop 32 bit binaries
 - update unix/win/mac 64 bit binaries
 - fixes #1598
 - refs #1594
@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Aug 25, 2017

Owner

Okay with those commits, everything should be fixed. Just some testing to do.

Owner

iBotPeaches commented Aug 25, 2017

Okay with those commits, everything should be fixed. Just some testing to do.

@iBotPeaches iBotPeaches closed this in #1597 Aug 25, 2017

@remenyo

This comment has been minimized.

Show comment
Hide comment
@remenyo

remenyo Jul 20, 2018

Is 32bit support ended?
On Nexus 5, 8.1 force closes the newest version and the log refers to #1594 issue here.

remenyo commented Jul 20, 2018

Is 32bit support ended?
On Nexus 5, 8.1 force closes the newest version and the log refers to #1594 issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment