Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align aapt/aapt2 codebases #1889

Closed
iBotPeaches opened this Issue Aug 31, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@iBotPeaches
Copy link
Owner

iBotPeaches commented Aug 31, 2018

Attempt to use the android-9.0.0_r3 tag and apply both our aapt1/aapt2 patches to the codebase and build every binary -_-

Will make long-term easier. API28 made some fixes for aapt1.

@iBotPeaches iBotPeaches added this to the 2.3.4 milestone Aug 31, 2018

@iBotPeaches iBotPeaches self-assigned this Aug 31, 2018

@dongfangxunlei

This comment has been minimized.

Copy link

dongfangxunlei commented Sep 1, 2018

Great! Can you also build for android platform? I don't want to download the large aosp source any more.
I think above 95% devices uses arm64 and x86_64, the other can be ignored.

@iBotPeaches

This comment has been minimized.

Copy link
Owner Author

iBotPeaches commented Sep 1, 2018

@dongfangxunlei Yes, I will build the Android builds.

  • Release 2.3.4 - Support for Android Pie
  • Release 2.4.0 - Add support for Android platform
@iBotPeaches

This comment has been minimized.

Copy link
Owner Author

iBotPeaches commented Sep 2, 2018

Aligning my codebases (updating them) is proving to be difficult due to the inclusion of the Manifest properties - aosp-mirror/platform_frameworks_base@11be931#diff-e7a93bfac1c422acb7946f9512eb2712

  • compileSdkVersion
  • compileSdkVersionCodename

These break the tests massively because old applications don't have these attributes, then rebuilt applications do. If we remove this feature, then new applications decoded will have the attributes stripped.

Removing these two attributes from being injected will make the tests easier, but unsure of the outcome of this.

@iBotPeaches iBotPeaches referenced this issue Sep 2, 2018

Merged

Align aapt1/aapt2 codebases #1891

7 of 7 tasks complete

iBotPeaches added a commit that referenced this issue Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.