Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Get rid of -v4 resource qualifiers #196
Original issue 85 created by Brut.alll on 2010-08-25T15:22:32.000Z:
and apktool adds it when some resources really has it.
Seems apps built for 2.2 target get sdk=4 qualifier by default, but not for all resources: e.g. drawables get it, but values not. I think I could just ignore sdk=4 qualifier - Cupcake is really old and if Google has set sdk=4 as default for SDK Tools, then seems they also think so.
Issue has low priority, cause it doesn't break anything - just makes decoded apps uglier.
Comment #1 originally posted by mrozdoba on 2010-08-25T17:37:30.000Z:
If not, my reading of the url you quoted is that this is done specifically to support Cupcake & pre, not because it's too old to bother supporting. Without -v4, as the resolution quantifier is not known by cupcake it is ignored, consequently the resolution quantified drawables are seen as equally valid as the default & might well be used. With the -v4 which cupcake understands, it will avoid those drawables correctly using the mdp defaults, this being correct as google asserts all 1.5 devices are mdp.
Comment #2 originally posted by Brut.alll on 2010-08-25T17:58:27.000Z:
Yes. If you'll create empty app for 2.2 target, build it and look into its resources, you'll see something like: http://pastebin.com/wBM0gnTX . As you can see all drawables got sdk=4 qualifier even if they're referencing dirs without -v4.
"Without -v4, as the resolution quantifier is not known by cupcake it is ignored (...)"
Negative, all densities got sdk=4. I don't really know, why they made sdk=4 default. Maybe they have introduced some PNG optimizations which Cupcake does not support. But this doesn't make much sense cause then app is practically useless on Cupcake, so why haven't they made minSdkVersion=4 default too?
Comment #3 originally posted by Brut.alll on 2010-08-29T15:23:22.000Z:
So yeah, you was, mrozdoba, right. Now I know exactly, what to do, thank you :-)