Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Windows binaries are busted. #1975

Closed
iBotPeaches opened this Issue Jan 7, 2019 · 3 comments

Comments

Projects
1 participant
@iBotPeaches
Copy link
Owner

iBotPeaches commented Jan 7, 2019

For some reason aapt\aapt2 x64 windows binaries are broken - they even don't output help info. X64 windows binaries building works without any issues with AOSP master branch, but for some reason binaries are broken with android-9.0.0_r22 branch(not tested android-9.0.0_r22 branch by myself as i have only master branch on my pc now). I've compared binaries:

Context - 261e163#commitcomment-31862000

@iBotPeaches iBotPeaches self-assigned this Jan 7, 2019

@iBotPeaches iBotPeaches added this to the 2.4.0 milestone Jan 7, 2019

iBotPeaches referenced this issue Jan 7, 2019

Merge pull request #1960 from iBotPeaches/android-9.0.0_r22
Sync aapt binaries with aapt1/aapt2 + no-crunch

@iBotPeaches iBotPeaches added this to High priority in Planned Release (2.4.0) Jan 9, 2019

@iBotPeaches

This comment has been minimized.

Copy link
Owner Author

iBotPeaches commented Jan 10, 2019

[ 98% 163/166] //frameworks/base/tools/aapt:aapt link aapt_64.exe [windows x86_64]
/home/ibotpeaches/Android/Sdk/prebuilts/gcc/linux-x86/host/x86_64-w64-mingw32-4.8/bin/../lib/gcc/x86_64-w64-mingw32/4.8.3/../../../../x86_64-w64-mingw32/bin/ld: warning: cannot find entry symbol _mainCRTStartup; defaulting to 0000000000401000

Yeah something isn't right with the linking. Perhaps my 9.0.0_r22 tag has some issues.

@iBotPeaches

This comment has been minimized.

Copy link
Owner Author

iBotPeaches commented Jan 10, 2019

Issue exists as well on 9.0.0_r30 tag

@iBotPeaches

This comment has been minimized.

Copy link
Owner Author

iBotPeaches commented Feb 16, 2019

Fixed on master.

Planned Release (2.4.0) automation moved this from High priority to Closed Feb 16, 2019

iBotPeaches added a commit that referenced this issue Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.