New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for broken file-resources. #202

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 91 created by Brut.alll on 2010-09-01T12:23:01.000Z:

If you got "S: Could not decode file" during decoding, then most probably you won't be able to rebuild this app, cause of public.xml references. This isn't that bad, cause if apk is broken, then why to work with it? And supporting broken apps is really hard, cause anything may be wrong.

But actually I should support some of cases to keep compatibility with Android OS. I mean... Android OS doesn't mind broken files, until it will try to do something with them. But what if there are some broken, unused files? Apk would work normally on a device, but it would be undecodable by apktool.

If apktool would replace all broken file-resources by <item /> tag, then you would be able to rebuild broken apks. And resulting apks would be very original-like.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by Brut.alll on 2010-09-03T16:11:20.000Z:

Fixed in v1.3.2 .

Still I don't know, what to do with people, who ignore decoding errors. Prior to v1.3.2 if you got problems with decoding some files, you probably couldn't build an app back. Using v1.3.2 you are able to rebuild an apk and you will get potential errors on a runtime. I'm afraid people won't inform me about decoding errors, when they will report issues :-/

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by Brut.alll on 2010-09-03T16:11:20.000Z:

Fixed in v1.3.2 .

Still I don't know, what to do with people, who ignore decoding errors. Prior to v1.3.2 if you got problems with decoding some files, you probably couldn't build an app back. Using v1.3.2 you are able to rebuild an apk and you will get potential errors on a runtime. I'm afraid people won't inform me about decoding errors, when they will report issues :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment