apktool doesn't regenerate configChanges="orientation|screenSize" #415

Closed
iBotPeaches opened this Issue Mar 18, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@iBotPeaches
Owner

iBotPeaches commented Mar 18, 2015

Original issue 304 created by nathan@janrain.com on 2012-02-11T04:10:23.000Z:

What steps will reproduce the problem?

  1. apktool d SimpleDemo-debug.apk
  2. examine AndroidManifest.xml, there is no screenSize in the configChanges attribute of the JRFragmentHostActivity activities.

What is the expected output? What do you see instead?

I expect to find the JRFragmentHostActivity activities to have configChanges attributes of "orientation|screenSize". Instead I see configChanges="orientation".

What version of the product are you using? On what operating system?

apktool1.4.3.tar.bz2 with apktool-install-macosx-r04-brut1.tar.bz2

Please provide any additional information below.

SimpleDemo-debug.apk was built with ant with project.properties target=android-15. The source manifest can be found here:
https://github.com/janrain/engage.android/blob/master/SimpleDemo/AndroidManifest.xml

I have seen this behavior with other APKs too. They behave on the device as if they do have the screensize attribute though.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #1 originally posted by rogerbinns on 2012-02-23T07:08:56.000Z:

This is also related to issue # 263

Owner

iBotPeaches commented Mar 18, 2015

Comment #1 originally posted by rogerbinns on 2012-02-23T07:08:56.000Z:

This is also related to issue # 263

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #2 originally posted by ruairitobrien on 2012-07-23T11:31:31.000Z:

I came across this before. It looks like apktool at some point creates a file: (Windows)C:\Users%Username%\apktool\framework\1.apk (Linux)/home/%Username%/apktool/framework/1.apk

Not sure how or when it is created but it looks like (purely guessing) it gets created on the first execution of the apktool. It appears that it does not get updated when you update the SDK.

Deleting that file and running apktool after updating the Android SDK seems to create a new framework/1.apk file that supports the latest SDK and should solve the issue mentioned above.

Owner

iBotPeaches commented Mar 18, 2015

Comment #2 originally posted by ruairitobrien on 2012-07-23T11:31:31.000Z:

I came across this before. It looks like apktool at some point creates a file: (Windows)C:\Users%Username%\apktool\framework\1.apk (Linux)/home/%Username%/apktool/framework/1.apk

Not sure how or when it is created but it looks like (purely guessing) it gets created on the first execution of the apktool. It appears that it does not get updated when you update the SDK.

Deleting that file and running apktool after updating the Android SDK seems to create a new framework/1.apk file that supports the latest SDK and should solve the issue mentioned above.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #3 originally posted by nathan@janrain.com on 2012-07-23T16:48:39.000Z:

I'll try that when I get a chance.

Owner

iBotPeaches commented Mar 18, 2015

Comment #3 originally posted by nathan@janrain.com on 2012-07-23T16:48:39.000Z:

I'll try that when I get a chance.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #4 originally posted by connor.tumbleson on 2012-11-17T00:06:06.000Z:

Issue 263 has been merged into this issue.

Owner

iBotPeaches commented Mar 18, 2015

Comment #4 originally posted by connor.tumbleson on 2012-11-17T00:06:06.000Z:

Issue 263 has been merged into this issue.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #5 originally posted by connor.tumbleson on 2012-11-17T14:47:30.000Z:

Issue 271 has been merged into this issue.

Owner

iBotPeaches commented Mar 18, 2015

Comment #5 originally posted by connor.tumbleson on 2012-11-17T14:47:30.000Z:

Issue 271 has been merged into this issue.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #6 originally posted by connor.tumbleson on 2012-11-19T13:00:29.000Z:

Issue 346 has been merged into this issue.

Owner

iBotPeaches commented Mar 18, 2015

Comment #6 originally posted by connor.tumbleson on 2012-11-19T13:00:29.000Z:

Issue 346 has been merged into this issue.

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #7 originally posted by connor.tumbleson on 2012-11-19T23:04:22.000Z:

<empty>

Owner

iBotPeaches commented Mar 18, 2015

Comment #7 originally posted by connor.tumbleson on 2012-11-19T23:04:22.000Z:

<empty>

@iBotPeaches

This comment has been minimized.

Show comment
Hide comment
@iBotPeaches

iBotPeaches Mar 18, 2015

Owner

Comment #8 originally posted by connor.tumbleson on 2012-12-19T14:12:35.000Z:

Fixed in v1.5.1

    <activity android:theme="@style/jr_dialog" android:name="com.janrain.android.engage.ui.JRFragmentHostActivity" android:configChanges="orientation|screenSize" android:windowSoftInputMode="stateHidden|adjustResize" />
Owner

iBotPeaches commented Mar 18, 2015

Comment #8 originally posted by connor.tumbleson on 2012-12-19T14:12:35.000Z:

Fixed in v1.5.1

    <activity android:theme="@style/jr_dialog" android:name="com.janrain.android.engage.ui.JRFragmentHostActivity" android:configChanges="orientation|screenSize" android:windowSoftInputMode="stateHidden|adjustResize" />
@zi6xuan

This comment has been minimized.

Show comment
Hide comment
@zi6xuan

zi6xuan Apr 13, 2016

Hello, I use apktool 2.1.0, this problem still occurs
Platform: windows8 32bit
JDK: jdk1.7.0_25

zi6xuan commented Apr 13, 2016

Hello, I use apktool 2.1.0, this problem still occurs
Platform: windows8 32bit
JDK: jdk1.7.0_25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment